SWRL rule ordering and minor href fix #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change orders swrl rules according to their rdfs:label and a minor fix to href in the body and head of the swrl rules.
|
Thanks, please next time commit to the |
dgarijo
reviewed
Apr 30, 2024
| @@ -52,7 +52,8 @@ Copyright (C) 2023, Victor Chavez <[email protected]> | |||
| <xsl:template name="get.swrl.toc"> | |||
| <ul class="hlist"> | |||
| <xsl:apply-templates select="/rdf:RDF/rdf:Description[rdf:type[@rdf:resource='http://www.w3.org/2003/11/swrl#Imp']]" mode="toc"> | |||
| <xsl:sort select="rdfs:comment" order="ascending" data-type="text"/> | |||
| <xsl:sort select="lower-case(f:getLabel(rdfs:label))" | |||
| order="ascending" data-type="text"/> | |||
There was a problem hiding this comment.
this triggers an error if the label does not exist
There was a problem hiding this comment.
I assumed all the swrl rules had an rdfs:label because in the SWRL Tab from Protégé the rdfs: label is always included.
I am not sure if this will work but we could perhaps check if the rdfs:label exists
<xsl:choose>
<xsl:when test="exists(rdfs:label)">
<xsl:sort select="lower-case(f:getLabel(rdfs:label))" order="ascending" data-type="text"/>
</xsl:when>
<xsl:otherwise>
<xsl:sort select="lower-case(f:getLabel(rdfs:comment))" order="ascending" data-type="text"/>
</xsl:otherwise>
</xsl:choose>
|
I added a fix and released a new version fixing this. No worries!
El mar., 30 abr. 2024 11:08 p. m., Victor Chavez ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In src/main/resources/lode/swrl-module.xsl
<#664 (comment)>:
> @@ -52,7 +52,8 @@ Copyright (C) 2023, Victor Chavez ***@***.***>
<xsl:template name="get.swrl.toc">
<ul class="hlist">
<xsl:apply-templates ***@***.***:resource='http://www.w3.org/2003/11/swrl#Imp']]" mode="toc">
- <xsl:sort select="rdfs:comment" order="ascending" data-type="text"/>
+ <xsl:sort select="lower-case(f:getLabel(rdfs:label))"
+ order="ascending" data-type="text"/>
I assumed all the swrl rules had an rdfs:label because in the SWRL Tab
from Protégé the rdfs: label is always included.
grafik.png (view on web)
<https://github.com/dgarijo/Widoco/assets/47216966/8cea37e8-11a0-4bbd-8fc7-7371877327f8>
I am not sure if this will work but we could perhaps check if the
rdfs:label exists
<xsl:choose>
<xsl:when test="exists(rdfs:label)">
<xsl:sort select="lower-case(f:getLabel(rdfs:label))" order="ascending" data-type="text"/>
</xsl:when>
<xsl:when test="exists(rdfs:comment)">
<xsl:sort select="lower-case(f:getLabel(rdfs:comment))" order="ascending" data-type="text"/>
</xsl:when>
</xsl:choose>
—
Reply to this email directly, view it on GitHub
<#664 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGXQLACQPUYRIQJLZRDZAAB3ZAVCNFSM6AAAAABBIK3O6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSGUZDKMJVHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
ok nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change orders swrl rules according to their rdfs:label and a minor fix to href in the body and head of the swrl rules.
PS: nice to know the other SWRL PR got merged. This PR should just introduce minor fixes.